mpvScripts: handle nested attrsets #359625
Open
+61
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbraud
added
1.severity: blocker
|
Fixed |
|
|
13 tasks
nbraud
added a commit
to uninsane/nixpkgs
that referenced
this pull request
Nov 27, 2024
|
Addressed merge conflict; I'm leaving things as-is for ease-of-review, but please use a squash merge (rather than leave a tangled knot of history forever) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
mpvScripts' automation to gracefully recurse into nested attrsets. As is, drvs grouped under a common attrset, do not have the generic tests added.No functional change introduced (same set of drvs, with the same drv hashes)
Blocks #347323
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.