Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the previously-broken
vllm
derivation to 0.6.4 and brings it into a functional state. Specifically I:compressed-tensors
,mistral-common
, andpartial-json-parser
)vllm
's subprocess spawn logic to ensure thatPYTHONPATH
is propagated to the childSmoke-tested with:
invoking
bin/vllm serve facebook/opt-125m --chat-template ./template.jinja
and thenbin/vllm chat
.Currently
rocm
is broken due totorch
butcpu
works.cuda
test is still running.Things done
cpu
target)nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.