Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vllm: 0.6.2 -> 0.6.4 #359609

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

vllm: 0.6.2 -> 0.6.4 #359609

wants to merge 4 commits into from

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Nov 27, 2024

This updates the previously-broken vllm derivation to 0.6.4 and brings it into a functional state. Specifically I:

  • introduce needed Python dependencies (compressed-tensors, mistral-common, and partial-json-parser)
  • rework how target selection is handled and introduce support for the CPU backend
  • fix vllm's subprocess spawn logic to ensure that PYTHONPATH is propagated to the child

Smoke-tested with:

let
  pkgs = import ./. {};

  cpu = pkgs.python3Packages.vllm;

  rocm = pkgs.python3Packages.vllm.override {
    torch = pkgs.python3Packages.torchWithRocm;
  };

  cuda = pkgs.python3Packages.vllm.override {
    torch = pkgs.python3Packages.torchWithCuda;
  };
in { inherit cpu rocm cuda; }

invoking bin/vllm serve facebook/opt-125m --chat-template ./template.jinja and then bin/vllm chat.

Currently rocm is broken due to torch but cpu works. cuda test is still running.

Things done

  • Built on platform(s)
    • x86_64-linux (using the cpu target)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is a dependency of vllm-0.6.4.
This is a dependency of vllm-0.6.4.
This is a dependency of vllm-0.6.4.
This also reworks how target selection is handled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant