Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.tensorflow: rename generated wheel from tensorflow_cpu to tensorflow #359605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 27, 2024

Things done

As we fetch the "cpu-only" tensorflow wheel, we get a package named tensorflow_cpu.
While import tensorflow works fine, our pythonRuntimeDepsCheck calls importlib.metadata.distribution('tensorflow') which fails with:

importlib.metadata.PackageNotFoundError: No package metadata was found for tensorflow

This PR introduces a (dirty) patch that renames the generated artifacts from tensorflow_cpu to tensorflow.

Note: This only affects x86_64-linux.

cc @mweinelt @SomeoneSerge

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant