python312Packages.tensorflow: rename generated wheel from tensorflow_cpu to tensorflow #359605
+91
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
As we fetch the "cpu-only" tensorflow wheel, we get a package named
tensorflow_cpu
.While
import tensorflow
works fine, ourpythonRuntimeDepsCheck
callsimportlib.metadata.distribution('tensorflow')
which fails with:This PR introduces a (dirty) patch that renames the generated artifacts from
tensorflow_cpu
totensorflow
.Note: This only affects
x86_64-linux
.cc @mweinelt @SomeoneSerge
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.