python3Packages.dlib: use pytestCheckHook #348185
Merged
+2
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomodachi94
requested changes
Oct 20, 2024
There was a problem hiding this comment.
Hello! The diff looks good, but I encourage you to modify your commit messages to use our commit conventions. I also encourage you to remove the merge commit (go to your branch, use git reset --hard HEAD~1 to remove the most recent commit made, then git push --force-with-lease), since it can pollute the commit history.
Otherwise, this is stellar for a first contribution.
|
Unable to request a review from @christopherpoole. I'll go ahead and merge this, it appears to work fine according to Ofborg. |
tomodachi94
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Python DLIB away from outdated setup.py test. (#331159)
(First pull request, let me know if I goofed)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.