Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-task: 3.38.0 -> 3.39.2 #347340

Merged
merged 4 commits into from
Oct 9, 2024
Merged

go-task: 3.38.0 -> 3.39.2 #347340

merged 4 commits into from
Oct 9, 2024

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Oct 8, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trim21 trim21 marked this pull request as ready for review October 8, 2024 20:59
@infinisil

This comment was marked as resolved.

@trim21
Copy link
Contributor Author

trim21 commented Oct 8, 2024

I want to write a script to generate new default.nix file once new version of go-task are release, is there a document how hash and vendorHash are calculated? Looks like it's not base64(sha256()) of content of refs/tags/v${version}.tar.gz orgo.mod

@SuperSandro2000
Copy link
Member

Just run go mod update on the package.

is there a document how hash and vendorHash are calculated? Looks like it's not base64(sha256()) of content of refs/tags/v${version}.tar.gz or go.mod

It is the nix hashed output of go mod vendor in a directory.

@trim21
Copy link
Contributor Author

trim21 commented Oct 8, 2024

Just run go mod update on the package.

do you mean go mod vendor ?

@trim21 trim21 closed this Oct 9, 2024
@trim21 trim21 deleted the patch-1 branch October 9, 2024 02:15
@trim21 trim21 restored the patch-1 branch October 9, 2024 02:15
@trim21 trim21 reopened this Oct 9, 2024
@trim21
Copy link
Contributor Author

trim21 commented Oct 9, 2024

sorry, I close this PR by accident

@SuperSandro2000
Copy link
Member

Just run go mod update on the package.

do you mean go mod vendor ?

I meant nix-update https://github.com/Mic92/nix-update but probably got distracted while writting

@SuperSandro2000 SuperSandro2000 merged commit 31c987a into NixOS:master Oct 9, 2024
24 checks passed
@trim21
Copy link
Contributor Author

trim21 commented Oct 9, 2024

Just run go mod update on the package.

do you mean go mod vendor ?

I meant nix-update https://github.com/Mic92/nix-update but probably got distracted while writting

It's actually just go mod vendor and nix hash path ./vendor

@trim21 trim21 deleted the patch-1 branch October 9, 2024 16:46
@Ramblurr
Copy link
Contributor


error: builder for '/nix/store/ax5di1cill14lmvbaksdldhvxbp7l8y7-go-task-3.39.2-go-modules.drv' failed with exit code 1;
       last 10 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/w611p6wgzs5x0zvs68w6yzxzlv6kkdnq-source
       > source root is source
       > Running phase: patchPhase
       > applying patch /nix/store/y5jgbbdi3jwpaidyq3yf9cn8spf0507q-fix-ldflags-version.patch
       > patching file internal/version/version.go
       > Reversed (or previously applied) patch detected!  Assume -R? [n]
       > Apply anyway? [n]
       > Skipping patch.
       > 1 out of 1 hunk ignored -- saving rejects to file internal/version/version.go.rej
       For full logs, run 'nix log /nix/store/ax5di1cill14lmvbaksdldhvxbp7l8y7-go-task-3.39.2-go-modules.drv'.

Just bumped nixos unstable in my flake, and I am getting this build error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants