Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-hakari: 0.9.30 -> 0.9.33 #346942

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

nartsisss
Copy link
Member

@nartsisss nartsisss commented Oct 6, 2024

  • Update package to 0.9.33 (diff)
  • Remove with lib; in meta

Should this package be moved to pkgs/by-name?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nartsisss nartsisss changed the title Update cargo hakari cargo-hakari: 0.9.30 -> 0.9.33 Oct 6, 2024
@ofborg ofborg bot requested a review from figsoda October 6, 2024 21:43
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4650

@nartsisss
Copy link
Member Author

@macalinao are you still maintaining this package? Can't choose you as a reviewer (bot too)

@pbsds
Copy link
Member

pbsds commented Oct 20, 2024

that means they have not accepted the invite email.

@pbsds
Copy link
Member

pbsds commented Oct 20, 2024

you're welcome to add yourself as a maintainer, and may then merge r-ryantm PRs if you do migrate to by-name. If you're not interested i can merge

@nartsisss
Copy link
Member Author

nartsisss commented Oct 21, 2024

@pbsds Done. Thanks!

Should I squash commits or is that ok?
image

@pbsbot
Copy link

pbsbot commented Oct 21, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 346942


x86_64-linux

✅ 1 package built:
  • cargo-hakari

@pbsds pbsds merged commit aca8144 into NixOS:master Oct 21, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants