Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lkl: downgrade to 5.15 #219434

Merged
merged 3 commits into from
Mar 4, 2023
Merged

lkl: downgrade to 5.15 #219434

merged 3 commits into from
Mar 4, 2023

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Mar 4, 2023

Description of changes

This should fix nix build -f nixos/release-combined.nix nixos.ova and thus unblock the unstable channel

I bisected lkl to find out that >=5.16 breaks the cptofs thing, but 5.15 still works fine for nftables checkRuleset purposes.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@K900 K900 merged commit 0ab7f2e into NixOS:master Mar 4, 2023
@vcunat
Copy link
Member

vcunat commented Mar 4, 2023

For reference, the ova build and unblocking need(ed) further fixes, like #219463

@yu-re-ka yu-re-ka deleted the lkl-5-15 branch March 4, 2023 11:41
@Mic92
Copy link
Member

Mic92 commented Nov 8, 2023

I recently did some upstream work. I didn't encountered a hang: lkl/linux#534 but fixed some other filesystem unmount issue. Maybe worth to give it a retry.

@Mic92
Copy link
Member

Mic92 commented Nov 8, 2023

Still seems to hang... One feature I added to cptofs recently is ownership..., which would be also interesting for make-disk-image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants