haskellPackages.git-annex: Add shellPath for the git-annex-shell.

[Chobbes]

Motivation for this change

Git annex comes with a shell (/bin/git-annex-shell), which can be used as a restricted login shell.

https://git-annex.branchable.com/git-annex-shell/

Unfortunately, you can't set a user's shell to pkgs.haskellPackages.git-annex because it was missing the shellPath attribute. Now you can!

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[cdepillabout]

Could you add a short comment here explaining this? (Basically just what you said in the body of your PR)

And could you change the base branch from master to haskell-updates? We try to send all haskell-related PRs to the haskell-updates branch.

[Chobbes]

Sure, one sec.

[Chobbes]

@cdepillabout donezo! :)

[cdepillabout]

@ofborg build haskellPackages.git-annex git-annex

[cdepillabout]

Uh-oh, it looks like git-annex doesn't currently build on haskell-updates:

$ nix-build -A git-annex
error: Package ‘hslua-module-version-1.0.1’ in /home/illabout/git/nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix:141350 is marked as broken, refusing to evaluate.

       a) To temporarily allow broken packages, you can use an environment variable
          for a single invocation of the nix tools.

            $ export NIXPKGS_ALLOW_BROKEN=1

        Note: For `nix shell`, `nix build`, `nix develop` or any other Nix 2.4+
        (Flake) command, `--impure` must be passed in order to read this
        environment variable.

       b) For `nixos-rebuild` you can set
         { nixpkgs.config.allowBroken = true; }
       in configuration.nix to override this.

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowBroken = true; }
       to ~/.config/nixpkgs/config.nix.
(use '--show-trace' to show detailed location information)

This is likely because we are currently in the process of updating to GHC-9.0.2: #160733

@Chobbes are you interested in trying to fix this up?

[sternenseemann]

Doesn’t really matter, you can check if it works without building by checking the attribute. Merging into master is also an alternative for now.

…

On 20. Feb 2022, at 09:17, Dennis Gosnell ***@***.***> wrote:  Uh-oh, it looks like git-annex doesn't currently build on haskell-updates: $ nix-build -A git-annex error: Package ‘hslua-module-version-1.0.1’ in /home/illabout/git/nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix:141350 is marked as broken, refusing to evaluate. a) To temporarily allow broken packages, you can use an environment variable for a single invocation of the nix tools. $ export NIXPKGS_ALLOW_BROKEN=1 Note: For `nix shell`, `nix build`, `nix develop` or any other Nix 2.4+ (Flake) command, `--impure` must be passed in order to read this environment variable. b) For `nixos-rebuild` you can set { nixpkgs.config.allowBroken = true; } in configuration.nix to override this. c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add { allowBroken = true; } to ~/.config/nixpkgs/config.nix. (use '--show-trace' to show detailed location information) This is likely because we are currently in the process of updating to GHC-9.0.2: #160733 @Chobbes are you interested in trying to fix this up? — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because your review was requested.

[Chobbes]

Not sure what you want me to do. I have tested that it still builds in master, and that I can set the shell appropriately for a user. In the version based off of haskell-updates the attribute is set:

nix-repl> outputs.legacyPackages.x86_64-linux.haskellPackages.git-annex.passthru.shellPath
"/bin/git-annex-shell"

I don't really know anything about the migration to ghc-9.0.2, so I'm not really interested in fixing that up (though, if somebody wants to point me in the right direction I might look into it in the future --- but probably not soon, unless this will be a quick fix).

Should I set this branch to be based on master again? Will that get the changes merged sooner?

[sternenseemann]

Yes, presumably it'd be stuck on haskell-updates for a bit, so targeting master may be prudent.

[Chobbes]

Alright, and to do that I should just rebase everything onto master again, and then we can merge? I can do that in a few hours :).

On Sun, Feb 20, 2022 at 11:02 sterni ***@***.***> wrote: Yes, presumably it'd be stuck on haskell-updates for a bit, so targeting master may be prudent. — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/NixOS/nixpkgs/pull/161002*issuecomment-1046268606__;Iw!!IBzWLUs!E_a4Ncmmho9FEgn5D7lr3UWR3g0FEta___anIWFCJWlmqKSOq8oqI1A2NSFPMHd3B4s$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABHZNAQEZAVWL5ESXVOBVODU4EGCDANCNFSM5O34O5MA__;!!IBzWLUs!E_a4Ncmmho9FEgn5D7lr3UWR3g0FEta___anIWFCJWlmqKSOq8oqI1A2NSFPI-pTAa8$> . Triage notifications on the go with GitHub Mobile for iOS <https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!IBzWLUs!E_a4Ncmmho9FEgn5D7lr3UWR3g0FEta___anIWFCJWlmqKSOq8oqI1A2NSFPcpbf1MQ$> or Android <https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!IBzWLUs!E_a4Ncmmho9FEgn5D7lr3UWR3g0FEta___anIWFCJWlmqKSOq8oqI1A2NSFPopLxHhA$>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Calvin Beck

[Chobbes]

Alright, I got this pointed back at master, and tested building my system with it and it seems good to go :). Thanks for all the help, I appreciate it! Let me know if I need to make any further changes.

[sternenseemann]

@ofborg build git-annex