Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feeds length and categories fixes #1516

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Conversation

dmchmk
Copy link
Contributor

@dmchmk dmchmk commented Jul 21, 2024

Hi guys! Recently I've tried to follow NixOS'es news feed, but faced some issues:

  1. There was no publicly available link to the feed (found it in the issues). Also mentioned in this issue
  2. When I imported feed url to my reader, it was flooded by ~200 entries from beginning of times (year 2004) unlike other feeds usually having 5-10 entries.

And since we're all foss-guys, I've decided to fix issues by myself:)

While fixing length of the rss-feed, I've discovered that trying to apply filter to const variable isn't a way to get some proper results.

And after making rss-feeds for different categories really differ, I've added three new links on the Blog page under category blocks.

image

@thilobillerbeck
Copy link
Collaborator

Hi, thanks for these awesome fixes. I have one small nitpick. Currently the RSS Feed links are below the buttons for category seleciton on mobile as well. I guess it'd be great if they maybe align to the side in the style of the category button (maybe outlined). What do you think about that?
image

@crertel
Copy link
Contributor

crertel commented Aug 19, 2024

@thilobillerbeck @tomberek Can we unblock this? It looks like a reasonable step forward, and we can do a design tweak later if need-be.

@thilobillerbeck
Copy link
Collaborator

Hi, this is not about blocking. I just did not find any time yet to re-review. I apologize that things move slowly and I try to put some time into this PR as soon as I can.

@crertel
Copy link
Contributor

crertel commented Aug 20, 2024

Gotcha, no worries! Sorry if I misread the discussion thread so far. :(

@dmchmk
Copy link
Contributor Author

dmchmk commented Aug 28, 2024

Hi, @thilobillerbeck, I've updated the mobile view as well

изображение

Copy link
Collaborator

@thilobillerbeck thilobillerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now! Thanks for the great work! <3

@thilobillerbeck thilobillerbeck merged commit b7be943 into NixOS:main Aug 28, 2024
1 of 2 checks passed
@crertel
Copy link
Contributor

crertel commented Aug 31, 2024

Looks sharp! Good work y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants