Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated matplotlib get_cmap() #185

Merged
merged 2 commits into from
May 21, 2024
Merged

Replace deprecated matplotlib get_cmap() #185

merged 2 commits into from
May 21, 2024

Conversation

penguinpee
Copy link
Contributor

@penguinpee penguinpee commented May 18, 2024 •
edited
Loading

The function has been removed from matplotlib >= 3.9.
Fixes #184

@penguinpee
Replace deprecated matplotlib get_cmap()
9ed49b6 
The function has been removed from matplotlib >= 3.9.
Fixes NeuralEnsemble#184
samuelgarcia
samuelgarcia reviewed May 21, 2024
View reviewed changes
ephyviewer/base.py Outdated Show resolved Hide resolved
@samuelgarcia
Copy link
Collaborator

Merci!

@samuelgarcia samuelgarcia merged commit 532cc1a into NeuralEnsemble:master May 21, 2024
1 of 10 checks passed
@penguinpee
Copy link
Contributor Author

I was pondering using .resampled(N). But I didn't see a difference in output with a quick local smoke test. But the N was there for a reason, I guess. ;)

@samuelgarcia
Copy link
Collaborator

No worry.
I put it just in case to get the same. I guess that the image rendering is also interpolating the color somehow so should be the same indeed.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelgarcia samuelgarcia samuelgarcia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures with Matplotlib 3.9
2 participants
@penguinpee @samuelgarcia