fix: S3 paths with fragments not working #2156
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing[901] @ ab60275 |
|
Testing[901] @ ab60275 had 5 FAILUREs. |
|
I'll check. I suspect it's some flaky tests (we have been having a few that I haven't fixed yet). |
savingoyal
reviewed
Dec 2, 2024
| @@ -600,7 +600,7 @@ def _url(self, key_value): | |||
| # returned are Unicode. | |||
| key = getattr(key_value, "key", key_value) | |||
| if self._s3root is None: | |||
| parsed = urlparse(to_unicode(key)) | |||
| parsed = urlparse(to_unicode(key), allow_fragments=False) | |||
There was a problem hiding this comment.
can you add a comment here calling out why allow_fragments needs to be set to False for posterity
savingoyal
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 paths with url fragments do not work with the Metaflow S3 client, but do work with boto3 directly. The cause is that any key we pass to S3 methods goes through
urlparse, of which we only usenetlocandpath. Fragments get parsed into their own key in the ParseResult.