Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: retry with only_system #2131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madhur-ob
Copy link
Collaborator

@madhur-ob madhur-ob commented Nov 4, 2024

Closes #1443

Consider the flow:

import time
from metaflow import FlowSpec, step, retry

class PlatformRetryFlow(FlowSpec):
    @retry(only_system=True)
    @step
    def start(self):
        time.sleep(10)
        print('fail', 1 / 0)
        self.next(self.end)

    @retry(only_system=True)
    @step
    def end(self):
        print("done!")

if __name__ == '__main__':
    PlatformRetryFlow()

@retry(only_system=True) works locally ✅ , but when used with argo workflows i.e.

python demo.py argo-workflows create
python demo.py argo-workflows trigger

The user exception is also retried --> which we don't want.. ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@retry that retries only system errors
1 participant