remove setting of metadata in Runner #2107
Open
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhur-ob
changed the title
| self._namespace_check = _namespace_check | ||
|
|
||
| # Set the metadata being passed.. | ||
| metadata(self._current_metadata) |
There was a problem hiding this comment.
we don't want to do this at all. Basically, we create a Metaflow object that has self.metadata in it. We want to initialize self.metadata to be the one from self._current_metadata.
| @@ -540,16 +548,17 @@ def _unpickle_284(self, data): | |||
| ) | |||
|
|
|||
| def _unpickle_2124(self, data): | |||
There was a problem hiding this comment.
need to add another version of course. So we can unpickle all versions of objects.
| run_object = Run(pathspec, _namespace_check=False) | ||
| run_object = Run( | ||
| pathspec, _namespace_check=False, _current_metadata=content.get("metadata") | ||
| ) | ||
| return ExecutingRun(self, command_obj, run_object) | ||
|
|
||
| def run(self, **kwargs) -> ExecutingRun: |
There was a problem hiding this comment.
I think there is something in deployer which is where I ran into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.