Only use a GPU value for Kubernetes that is non-null and non-zero #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcguire81
commented
Aug 30, 2024
saikonen
reviewed
Oct 15, 2024
| # If GPU count is specified, explicitly set it in self.attributes. | ||
| if k == "gpu" and v != None: | ||
| # If GPU count is specified and non-zero, explicitly set it in self.attributes. | ||
| if k == "gpu" and v: |
There was a problem hiding this comment.
looking into alternatives for this at the moment. Note that the default from resources deco is actually "0" and not int, so it will pass this check.
There was a problem hiding this comment.
Hmm, I wonder if it's cast before it ends up here, because the type in the comments in int. Also, this seems to fix the problem, which is my biggest priority for removing the footgun; setting the default in the decorator to None would also expedite the fix, so that works, as well.
I can add some logging to capture the default values, here, to demonstrate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2005