Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JUnit4 to Junit5 #372

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Upgrade JUnit4 to Junit5 #372

wants to merge 5 commits into from

Conversation

cypherean
Copy link

@cypherean cypherean commented Mar 20, 2023 •
edited
Loading

Context

Upgrades JUnit4 to JUnit5.
Fixes #369

Doesn't upgrade mantis-control-plane-server due to issues with akka package

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@cypherean cypherean had a problem deploying to Integrate Pull Request March 20, 2023 18:54 — with GitHub Actions Failure
@cypherean cypherean had a problem deploying to Integrate Pull Request March 20, 2023 19:08 — with GitHub Actions Failure
@sundargates
Copy link
Collaborator

Is this ready for review?

@cypherean
Copy link
Author

Not yet, there's a minor issue with one of the submodules that I'm trying to fix

@cypherean
Copy link
Author

cypherean commented Mar 24, 2023 •
edited
Loading

Update @sundargates :
After upgrading to JUnit5 there's an issue with ResourceClusterActorTest. The actors are not being spawned so the resource cluster is throwing AskTimeoutException.

I've been trying to resolve this for quite some time. Can you help me with the same?

@cypherean cypherean had a problem deploying to Integrate Pull Request March 24, 2023 21:37 — with GitHub Actions Failure
@cypherean cypherean had a problem deploying to Integrate Pull Request April 10, 2023 17:29 — with GitHub Actions Failure
@cypherean cypherean had a problem deploying to Integrate Pull Request April 10, 2023 18:22 — with GitHub Actions Failure
@cypherean cypherean marked this pull request as ready for review April 10, 2023 18:22
@cypherean
Copy link
Author

@sundargates following our conversation during office hours, I've left mantis-control-plane-server as it is on JUnit4 for now. I'll try to tackle that issue. Rest of the submodules have been upgraded to JUnit5, and PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@jeffchao jeffchao Awaiting requested review from jeffchao

@piygoyal piygoyal Awaiting requested review from piygoyal

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@sundargates sundargates Awaiting requested review from sundargates sundargates is a code owner

@Andyz26 Andyz26 Awaiting requested review from Andyz26 Andyz26 is a code owner

@hmitnflx hmitnflx Awaiting requested review from hmitnflx hmitnflx is a code owner

@markcho markcho Awaiting requested review from markcho

@liuml07 liuml07 Awaiting requested review from liuml07

@fdc-ntflx fdc-ntflx Awaiting requested review from fdc-ntflx fdc-ntflx is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade junit to junit5 in subprojects
2 participants
@cypherean @sundargates