Make the plugin output directory configurable #356
Conversation
kilink
force-pushed
the
configurable-output-dir
branch
from
77d957f
to
42f2b7f
Compare
| @BeforeEach | ||
| fun setUp() { | ||
| val projectResourcePath = Paths.get("src", "test", "resources", "test-project") | ||
| projectResourcePath.toFile().copyRecursively(target = projectDir.toFile()) |
There was a problem hiding this comment.
The tests were writing to the resources directory, which could make them nondeterministic. I switched them to use a temporary directory and copy the project files into it between each test case.
|
|
||
| open class GenerateJavaTask : DefaultTask() { | ||
| @Input | ||
| var generatedSourcesDir: String = project.buildDir.absolutePath |
There was a problem hiding this comment.
I kind of feel like this property should be deprecated, and people should just set the outputDir directly if they need to customize it. Thoughts?
There was a problem hiding this comment.
I agree, I don't think anyone is using it per se.
There was a problem hiding this comment.
Just checked internal usages and we have a few. We can get rid of it in a subsequent release after I've given them a heads up to switch to using outputDir
|
Would fix #281 |
Make outputDir configurable, so that users can have full control over the output path. Additionally, the GenerateJavaTask lazy by converting inputs to gradle Properties. See: https://docs.gradle.org/current/userguide/lazy_configuration.html
kilink
force-pushed
the
configurable-output-dir
branch
from
42f2b7f
to
e65ba3b
Compare
|
@kilink could you please rebase with the latest master, as time allows. |
Make outputDir configurable, so that users can have full control over the output path.
Additionally, the GenerateJavaTask lazy by converting inputs to gradle Properties.
See: https://docs.gradle.org/current/userguide/lazy_configuration.html