Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a metric to track "Wrong key returned" errors #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a metric to track "Wrong key returned" errors #111

wants to merge 1 commit into from

Commits on Apr 24, 2021

  1. Add a metric to track "Wrong key returned" errors 

    This change adds "wrongKeyReturned" as a metric and increments it
everytime we see it in action.

This change was added as we noticed some of these error messages in
the logs, and we'd like to track the frequence of these errors.

Note that even prior to this change, we did not return the wrong key
back to the calling application but instead count it as a miss.

Print stack trace when we notice a Wrong Key error

Consolidate duplicate code under checkWrongKeyReturned()

Address review comments for wrong key returned metric

- Better logging to catch if returned key is from a different host
- Make sure stack trace goes to logs instead of stdout
- Naming nits addressed
    @smukil
    smukil committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    c385fad View commit details
    Browse the repository at this point in the history