Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric to track "Wrong key returned" errors #108

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

smukil
Copy link
Contributor

@smukil smukil commented Apr 20, 2021

This change adds "wrongKeyReturned" as a metric and increments it
everytime we see it in action.

This change was added as we noticed some of these error messages in
the logs, and we'd like to track the frequence of these errors.

Note that even prior to this change, we did not return the wrong key
back to the calling application but instead count it as a miss.

This change adds "wrongKeyReturned" as a metric and increments it
everytime we see it in action.

This change was added as we noticed some of these error messages in
the logs, and we'd like to track the frequence of these errors.

Note that even prior to this change, we did not return the wrong key
back to the calling application but instead count it as a miss.
@smukil smukil self-assigned this Apr 20, 2021
Copy link
Contributor

@arunagrawal84 arunagrawal84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Consider creating a method to log error, increment and print stack trace.

@smukil
Copy link
Contributor Author

smukil commented Apr 21, 2021

nit: Consider creating a method to log error, increment and print stack trace.

Thanks @arunagrawal84 . Added a new commit to do so.

- Better logging to catch if returned key is from a different host
- Make sure stack trace goes to logs instead of stdout
- Naming nits addressed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants