Add fixture to cleanup dataloader after each test runs #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fixture to cleanup dataloader after each test runs. This ensures that if a test using the Merlin Dataloader only partially consumes a dataloader instance (and isn't using it as a context manager (with statement), or calling stop explicitly). Then we automatically clean it up by calling stop on it (it's ok if we call stop more than once).
Related:
.stop()
on dataloader intest_dataloader_schema
NVTabular#1848Background
In the scenario where we have a partially consumed dataloader in a test. When combined with something like
pytest-cov
which scans subprocesses, this can result in the dataloader background thread hanging around and onto resources that conflict with subsequent tests. In NVTabular this resulted in subsequent tests of operators to take significantly longer than usual (>5 hours instead of ~20 mins)