Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BSL in ERI calculation #749

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix BSL in ERI calculation #749

merged 2 commits into from
Oct 23, 2024

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Oct 23, 2024 •
edited
Loading

Pull Request Description

Fixes double counting of battery storage losses in ERI calculation; CO2e Index is unaffected.

Checklist

Not all may apply:

  • OS-HPXML git subtree has been pulled
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., rulesets\tests and/or workflow/tests/*_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results on CI

@shorowit shorowit added the bug label Oct 23, 2024
@shorowit shorowit self-assigned this Oct 23, 2024
Base automatically changed from cfis_control_type to latest-os-hpxml October 23, 2024 21:24
@shorowit shorowit marked this pull request as ready for review October 23, 2024 21:51
@shorowit shorowit merged commit 8f69188 into latest-os-hpxml Oct 23, 2024
@shorowit shorowit deleted the fix_bsl_eri branch October 23, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shorowit