Add a problem matcher for gcc warnings/errors: for develop commits, and branch of PR #10832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
DoNotPublish
jmarrec
commented
Nov 25, 2024
Comment on lines
+1
to
+17
| { | ||
| "problemMatcher": [ | ||
| { | ||
| "owner": "gcc-problem-matcher", | ||
| "pattern": [ | ||
| { | ||
| "regexp": "^(.*?):(\\d+):(\\d*):?\\s+(?:fatal\\s+)?(warning|error):\\s+(.*)$", | ||
| "file": 1, | ||
| "line": 2, | ||
| "column": 3, | ||
| "severity": 4, | ||
| "message": 5 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
cf https://regex101.com/r/4mPjR3/1 for demo
Comment on lines
138
to
141
| run: | | ||
| echo "::add-matcher::.github/workflows/cpp-problem-matcher.json" | ||
| cmake --build . -j ${{ matrix.nproc }} --config Release | ||
| echo "::remove-matcher owner=gcc-problem-matcher::" |
There was a problem hiding this comment.
building develop commits, we add it, build, and remove it.
Comment on lines
158
to
161
| run: | | ||
| echo "::add-matcher::.github/workflows/cpp-problem-matcher.json" | ||
| cmake --build . -j ${{ matrix.nproc }} --config Release | ||
| echo "::remove-matcher owner=gcc-problem-matcher::" |
There was a problem hiding this comment.
Testing PR: enable it only when building the PR branch (not develop for regression)
Merged
jmarrec
commented
Nov 25, 2024
|
Nailed it! OK, so the add-matcher command seems to ignore working-directory. Good to know. Thanks @jmarrec this was fun and will be very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pwned from https://github.com/microsoft/vscode-cpptools/blob/bfa3c7544ef63e7e0b6d0bd6bf8a1363ed3c4deb/Extension/package.json#L439
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.