Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Std. 62.1 VRP calculations for Secondary Recirculation Systems #10775

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix Std. 62.1 VRP calculations for Secondary Recirculation Systems #10775

wants to merge 2 commits into from

Conversation

EnergyArchmage
Copy link
Contributor

Pull request overview

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@EnergyArchmage EnergyArchmage added the Defect Includes code to repair a defect in EnergyPlus label Sep 30, 2024
@github-actions GitHub Actions
Copy link

⚠️ Regressions detected on macos-14 for commit a3f1dbc

Regression Summary
  • EIO: 1
  • ESO Big Diffs: 1
  • Table Big Diffs: 1

mjwitte
mjwitte approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mjwitte mjwitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EnergyArchmage The code and revised output agree with the description in the issue.
For both test files, for heating, Zone Ventilation Efficiency - Evz is now roughly 1.3 for all zones. Is that what's expected here?

@nrel-bot
Copy link

@EnergyArchmage @Myoldmopar it has been 28 days since this pull request was last updated.

@EnergyArchmage
Copy link
Contributor Author

Evz is now roughly 1.3 for all zones. Is that what's expected here?

yes, that is correct

@github-actions GitHub Actions
Copy link

⚠️ Regressions detected on macos-14 for commit ebefd10

Regression Summary
  • EIO: 1
  • ESO Big Diffs: 1
  • Table Big Diffs: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwitte mjwitte mjwitte approved these changes

Assignees
No one assigned
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standard 62.1 Secondary Recirculation VRP Calculation Errors
5 participants
@EnergyArchmage @nrel-bot @mjwitte @nrel-bot-2 @nrel-bot-2c