Update UnitarySystem set point control

[rraustad]

Pull request overview

• Fixes AirloopHVAC:UnitarySystem set point control does not turn on cooling coil #10570
• Testing showed that set point controls in UnitarySystem did not turn on the cooling coil and other coils did not respond as anticipated.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

This branch shows all coils now turn on and set point is maintained except for when the AvailabilityManger is turning off the system at night for a few hours and on a weekend. I'm not exactly sure yet where the change in air flow from cooling to heating is coming from.

Component Sizing Information, Fan:SystemModel, SUPPLY FAN 1, User-Specified Design Maximum Air Flow Rate [m3/s], 1.00000
Component Sizing Information, AirLoopHVAC:UnitarySystem, WATER-TO-AIR HEAT PUMP UNIT 1, User-Specified Supply Air Flow Rate [m3/s], 1.00000
Component Sizing Information, AirLoopHVAC:UnitarySystem, WATER-TO-AIR HEAT PUMP UNIT 1, User-Specified Heating Supply Air Flow Rate [m3/s], 1.00000
Component Sizing Information, AirLoopHVAC:UnitarySystem, WATER-TO-AIR HEAT PUMP UNIT 1, User-Specified Cooling Supply Air Flow Rate [m3/s], 1.00000
Component Sizing Information, AirLoopHVAC:UnitarySystem, WATER-TO-AIR HEAT PUMP UNIT 1, User-Specified No Load Supply Air Flow Rate [m3/s], 0.00000
Component Sizing Information, COIL:COOLING:WATERTOAIRHEATPUMP:VARIABLESPEEDEQUATIONFIT, SYS 1 HEAT PUMP COOLING MODE, Design Size Rated Air Flow Rate [m3/s], 1.00000
Component Sizing Information, COIL:COOLING:WATERTOAIRHEATPUMP:VARIABLESPEEDEQUATIONFIT, SYS 1 HEAT PUMP COOLING MODE, User-Specified Rated Air Flow Rate [m3/s], 1.00000

[nrel-bot-3]

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot-2c]

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot]

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot-2]

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot-2c]

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot-2]

@rraustad it has been 16 days since this pull request was last updated.