Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obselete entries and add "reduce obs space" option iasi filter #29

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove obselete entries and add "reduce obs space" option iasi filter #29

wants to merge 2 commits into from

Conversation

emilyhcliu
Copy link

@emilyhcliu emilyhcliu commented Sep 24, 2024 •
edited
Loading

This PR proposes the following changes for IASI:

  1. Remove obsolete entries related to QC flags in the observation filter
  2. Rename mtiasi to iasi
  3. Add `reduce obs space

There is a companion GDASApp PR #1292
This partly resolves Issue NOAA-EMC/GDASApp#1291

@emilyhcliu emilyhcliu mentioned this pull request Sep 24, 2024
Open
@emilyhcliu
Copy link
Author

@danholdaway Thanks for reviewing this PR.

@emilyhcliu
Copy link
Author 

Test failed with the following message:platform linux -- Python 3.12.6, pytest-8.3.3, pluggy-1.5.0 -- /opt/hostedtoolcache/Python/3.12.6/x64/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/jcb-gdas/jcb-gdas/jcb_repo
collecting ... collected 5 items

Error: The operation was canceled.

This does not look like a working test.
Can we merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danholdaway danholdaway danholdaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilyhcliu @danholdaway