Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Reimplement ATLAS Z0 7TEV 46FB Dataset #2237

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ecole41
Copy link
Collaborator

@ecole41 ecole41 commented Dec 4, 2024

This pull request is merging the two CC and CF datasets into one filter.py script.
Functions haves been added to produce the data central, kinematic and uncertainties yaml files for both of these datasets.

Old vs New Data

CC Dataset: https://vp.nnpdf.science/SpiOHitcS-2WggfpKcLW3Q==/

CF Dataset: https://vp.nnpdf.science/D3121rJ6RWG3IgyqViXJMw==/

Compatibility Check:

from validphys.api import API
import numpy as np
 
inp1 = {"dataset_input": {"dataset": "ATLASZRAP11CC"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
inp2 = {"dataset_input": {"dataset": "ATLASZRAP11CC", "variant": "legacy"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
 
covmat1 = API.covmat_from_systematics(**inp1)
covmat2 = API.covmat_from_systematics(**inp2)
 
t0_covmat1 = API.t0_covmat_from_systematics(**inp1)
t0_covmat2 = API.t0_covmat_from_systematics(**inp2)
 
result = np.all(np.isclose(covmat1, covmat2))
result_2 = np.all(np.isclose(t0_covmat1, t0_covmat2))

print('covmat', result)
print('t0_covmat', result_2)

inp3 = {"dataset_input": {"dataset": "ATLASWZRAP11CF"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
inp4 = {"dataset_input": {"dataset": "ATLASWZRAP11CF", "variant": "legacy"}, "theoryid": 40_000_000, "use_cuts": "internal", "t0pdfset": "NNPDF40_nnlo_as_01180", "use_t0": True}
 
covmat3 = API.covmat_from_systematics(**inp3)
covmat4 = API.covmat_from_systematics(**inp4)
 
t0_covmat3 = API.t0_covmat_from_systematics(**inp3)
t0_covmat4 = API.t0_covmat_from_systematics(**inp4)
 
result3 = np.all(np.isclose(covmat3, covmat4))
result_4 = np.all(np.isclose(t0_covmat3, t0_covmat4))

print('covmat', result3)
print('t0_covmat', result_4)

[Out]:

covmat True
t0_covmat True
covmat True
t0_covmat True

@scarlehoff
Copy link
Member

Hi @ecole41 this is not ready for rewview yet right? I see that the variables are still called k1/k2/k_i etc for instance.

@ecole41
Copy link
Collaborator Author

ecole41 commented Dec 4, 2024

Hi @ecole41 this is not ready for rewview yet right? I see that the variables are still called k1/k2/k_i etc for instance.

No, this is not ready yet. I will keep working on it

@scarlehoff
Copy link
Member

Ok! No problem! Is any of the PR finished? There are now many and I got a bit lost. So that I can review (and hopefully merge) the ones that are

@ecole41
Copy link
Collaborator Author

ecole41 commented Dec 5, 2024

Ok! No problem! Is any of the PR finished? There are now many and I got a bit lost. So that I can review (and hopefully merge) the ones that are

Yes, #2178 and #2202 should be ready unless there is something that I have missed.

@ecole41
Copy link
Collaborator Author

ecole41 commented Dec 11, 2024

This branch should be complete, but is failing the checks. I have merged from the master so am not sure why this is happening

@RoyStegeman RoyStegeman requested review from jacoterh and removed request for jacoterh December 11, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants