Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PineAPPL version to v1 #2217

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

Radonirinaunimi
Copy link
Member

For the time being, this is primarily needed because pineko (NNPDF/pineko#206) depends on it. This does not introduce physic's changes yet, ie still does not allow for an arbitrary number of convolutions.

@Radonirinaunimi Radonirinaunimi marked this pull request as draft November 18, 2024 16:51
@scarlehoff
Copy link
Member

sorry, wouldn't it be better to instead of having a branch here just for the pineko dev branch, to remove for now nnpdf from the pineko dev branch?

Or do you need nnpdf there?

@Radonirinaunimi
Copy link
Member Author

sorry, wouldn't it be better to instead of having a branch here just for the pineko dev branch, to remove for now nnpdf from the pineko dev branch?

Or do you need nnpdf there?

Yes, nnpdf would be needed there, not only for some tests (which I'd like all of them to pass) but also to fully test that the evolution pipeline is working perfect. But also, as soon as v1 is available, we'll need to upgrade asap anyway in order to get rid of the reliance on the PineAPPL metadata (and ofc a bit later on to generalize to arbitrary convolution).

Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then! I've left some small comments, although it is WIP I thought better to mention these small points sooner rather than later.

Just one question, in principle old fktables we will always be able to read, right?

validphys2/src/validphys/coredata.py Outdated Show resolved Hide resolved
validphys2/src/validphys/pineparser.py Show resolved Hide resolved
validphys2/src/validphys/pineparser.py Show resolved Hide resolved
@Radonirinaunimi
Copy link
Member Author

ok then! I've left some small comments, although it is WIP I thought better to mention these small points sooner rather than later.

Thanks for the comments @scarlehoff!

Just one question, in principle old fktables we will always be able to read, right?

Yes, old FK tables will still be read as before perfectly. The only difference is that now when PineAPPL reads these FK tables it'll add onto them the new attributes (for e.g. convolutions) .

@Radonirinaunimi Radonirinaunimi added the waiting-pineappl-v1 Waiting for the release of PineAPPL v1 label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies waiting-pineappl-v1 Waiting for the release of PineAPPL v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants