-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PineAPPL version to v1
#2217
base: master
Are you sure you want to change the base?
Conversation
sorry, wouldn't it be better to instead of having a branch here just for the pineko dev branch, to remove for now nnpdf from the pineko dev branch? Or do you need nnpdf there? |
Yes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then! I've left some small comments, although it is WIP I thought better to mention these small points sooner rather than later.
Just one question, in principle old fktables we will always be able to read, right?
Thanks for the comments @scarlehoff!
Yes, old FK tables will still be read as before perfectly. The only difference is that now when PineAPPL reads these FK tables it'll add onto them the new attributes (for e.g. |
For the time being, this is primarily needed because
pineko
(NNPDF/pineko#206) depends on it. This does not introduce physic's changes yet, ie still does not allow for an arbitrary number of convolutions.