-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement Atlas Z0 8 TeV lowmass #2205
base: master
Are you sure you want to change the base?
Conversation
nnpdf_data/nnpdf_data/commondata/ATLAS_Z0_8TEV_LOWMASS/filter.py
Outdated
Show resolved
Hide resolved
Hi @comane, you need to run the |
2bd9a64
to
69a33a2
Compare
|
||
elif (sys[0]['name'] == 'ATLAS_LUMI') or (sys[0]['name'] == 'Lumi:M'): | ||
error_definitions[sys[0]['name']] = { | ||
"description": f"{sys[0]['name']}", | ||
"treatment": "MULT", | ||
"type": "UNCORR", | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A possible bug here is that the LUMI in the legacy implementation was treated as UNCORR.
It should however be CORR (ATLASLUMI12). If I set it to CORR, however, the chi2 changes by an order of magnitude (see report)
Am I missing something here or is it genuine?
Possible bugs were found in the old implementation:
-> I have incorporated this modification as it makes not a big difference
(this branch) https://vp.nnpdf.science/XpC1u8GqSyapV3e-ffvpwg==
(master) https://vp.nnpdf.science/7KddpIE6S9u2aBAfuTybkQ==