Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose variants as a tuple #2147

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

scarlehoff
Copy link
Member

@scarlehoff scarlehoff commented Aug 20, 2024

This might be necessary going forward to avoid having "legacy", "legacy_with_old_theory", etc.

For now just a draft since it needs tests and if it ends up being necessary only for a bunch of datasets it might be avoidable... I'd like to drop all theories below 700 tbh.

e.g.,

dataset_inputs:
    - {dataset: ATLAS_JETS, variant=("legacy", "old_theory")}

Closes #1964

@scarlehoff scarlehoff added the run-fit-bot Starts fit bot from a PR. label Oct 23, 2024
Copy link

Greetings from your nice fit 🤖 !
I have good news for you, I just finished my tasks:

Check the report carefully, and please buy me a ☕ , or better, a GPU 😉!

@scarlehoff scarlehoff removed the run-fit-bot Starts fit bot from a PR. label Nov 23, 2024
@scarlehoff scarlehoff force-pushed the accept_variant_as_a_list branch from 4451599 to deb8c60 Compare November 23, 2024 17:40
…ssibility of studying the effect of new theories -which might be differently architectured in some ways- in legacy datasets
@scarlehoff scarlehoff force-pushed the accept_variant_as_a_list branch from deb8c60 to caa8b69 Compare December 4, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept variant as a list
1 participant