Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbar failes with pymbar>3.0.3 #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mbar failes with pymbar>3.0.3 #122

wants to merge 1 commit into from

Conversation

dnlbauer
Copy link

@dnlbauer dnlbauer commented Mar 3, 2020

There seem to be a breaking change in pymbar because the calculation fails with the newest version and the following error:

Traceback (most recent call last):
  File "/home/<username>/.local/bin/alchemical_analysis", line 10, in <module>
    sys.exit(main())
  File "/home/<username>/.local/lib/python2.7/site-packages/alchemical_analysis/alchemical_analysis.py", line 1269, in main
    Deltaf_ij, dDeltaf_ij = estimatewithMBAR(u_kln, N_k, P.relative_tolerance, regular_estimate=True)
  File "/home/<username>/.local/lib/python2.7/site-packages/alchemical_analysis/alchemical_analysis.py", line 334, in estimatewithMBAR
    O = MBAR.computeOverlap()[2]
KeyError: 2

I pinned it down to version 3.0.3 is working, but 3.0.4 is not.

There seem to be a breaking change in pymbar because the calculation fails with the newest version and the following error:

``` python
Traceback (most recent call last):
  File "/home/yg38ymab/.local/bin/alchemical_analysis", line 10, in <module>
    sys.exit(main())
  File "/home/yg38ymab/.local/lib/python2.7/site-packages/alchemical_analysis/alchemical_analysis.py", line 1269, in main
    Deltaf_ij, dDeltaf_ij = estimatewithMBAR(u_kln, N_k, P.relative_tolerance, regular_estimate=True)
  File "/home/yg38ymab/.local/lib/python2.7/site-packages/alchemical_analysis/alchemical_analysis.py", line 334, in estimatewithMBAR
    O = MBAR.computeOverlap()[2]
KeyError: 2

```

I pinned it down to version 3.0.3 is working, but 3.0.4 is not.
@mrshirts
Copy link
Contributor

mrshirts commented Mar 3, 2020

Check the pymbar documentation github website. 3.0.5 should return the default to the old way of returning data - as tuples, instead of dictionaries.

alchemlyb will be replacing alchemical analysis in the neaer future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants