Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add snap dummy descriptions copied from ethereum provider and get revoke e2e test passing and snaps permissions unit tests passing #27965

Merged

Conversation

shanejonas
Copy link
Contributor

@shanejonas shanejonas commented Oct 18, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@shanejonas shanejonas requested review from a team as code owners October 18, 2024 15:14
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@shanejonas shanejonas changed the title fix: add snap dummy descriptions copied from ethereum provider and get revoke e2e test passing fix: add snap dummy descriptions copied from ethereum provider and get revoke e2e test passing and snaps permissions unit tests passing Oct 18, 2024
@shanejonas shanejonas force-pushed the sj/caip25-permission-migrations branch from 174e05b to 1f6ba4e Compare October 18, 2024 19:10
@shanejonas shanejonas merged commit e2d8305 into caip25-permission-migration Oct 18, 2024
63 of 68 checks passed
@shanejonas shanejonas deleted the sj/caip25-permission-migrations branch October 18, 2024 19:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants