Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add ui render for debug ui integration tests #27621

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

cryptotavares
Copy link
Contributor

@cryptotavares cryptotavares commented Oct 4, 2024

Description

This PR adds UI rendering capabilities for debugging UI integration tests. It introduces the jest-preview package to allow visual inspection of component states during test execution.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

  1. Run the UI integration tests with the new debug rendering enabled
  2. Verify that component states can be visually inspected during test runs

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 4, 2024
Copy link

socket-security bot commented Oct 4, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] environment 0 2.48 MB nicolo-ribaudo
npm/@polka/[email protected] None 0 4.49 kB lukeed
npm/@svgr/[email protected] None 0 13.2 kB neoziro
npm/@svgr/[email protected] None 0 5.01 kB neoziro
npm/@svgr/[email protected] None 0 3.71 kB neoziro
npm/@svgr/[email protected] None 0 7.04 kB neoziro
npm/@svgr/[email protected] None 0 13.8 kB neoziro
npm/@svgr/[email protected] None 0 7.99 kB neoziro
npm/@svgr/[email protected] None 0 13 kB neoziro
npm/@svgr/[email protected] None 0 31.5 kB neoziro
npm/@svgr/[email protected] None 0 15.4 kB neoziro
npm/@svgr/[email protected] None 0 25.1 kB neoziro
npm/@svgr/[email protected] None 0 72.9 kB neoziro
npm/@svgr/[email protected] None 0 12.6 kB neoziro
npm/@szmarczak/[email protected] None 0 6.3 kB szmarczak
npm/[email protected] None 0 7.68 kB nexdrew
npm/[email protected] None 0 18.4 kB sindresorhus
npm/[email protected] network +1 29.1 kB lukechilds
npm/[email protected] None 0 6.14 kB sindresorhus
npm/[email protected] None +2 20 kB sindresorhus
npm/[email protected] None +1 7.12 kB sindresorhus
npm/[email protected] network 0 5.45 kB szmarczak
npm/[email protected] None 0 6.28 kB sindresorhus
npm/[email protected] Transitive: filesystem +1 11.7 kB callumacrae
npm/[email protected] environment, filesystem +1 17.8 kB sindresorhus
npm/[email protected] filesystem, network +2 133 kB sindresorhus
npm/[email protected] filesystem 0 3.39 kB sindresorhus
npm/[email protected] Transitive: environment +1 16.4 kB watson
npm/[email protected] filesystem 0 3.61 kB sindresorhus
npm/[email protected] None 0 5.1 kB sindresorhus
npm/[email protected] None 0 2.55 kB litomore
npm/[email protected] environment, filesystem, shell Transitive: unsafe +3 857 kB nvh95
npm/[email protected] None 0 5.44 kB dominictarr
npm/[email protected] None 0 14.7 kB lukechilds
npm/[email protected] None 0 4.29 kB sindresorhus
npm/[email protected] None 0 7 kB yeikos
npm/[email protected] None 0 32.7 kB lukeed
npm/[email protected] None 0 18.1 kB sindresorhus
npm/[email protected] None 0 12.5 kB sindresorhus
npm/[email protected] network 0 14.3 kB sindresorhus
npm/[email protected] None 0 27 kB ryanzim
npm/[email protected] None 0 2.98 kB sindresorhus
npm/[email protected] None 0 4.94 kB sindresorhus
npm/[email protected] filesystem 0 4.22 kB trysound
npm/[email protected] environment 0 12 kB rexxars
npm/[email protected] None 0 4.33 kB sindresorhus
npm/[email protected] None +1 7.08 kB lukechilds
npm/[email protected] None 0 5.24 kB sindresorhus
npm/[email protected] filesystem 0 20.7 kB lukeed
npm/[email protected] None 0 48.9 kB trysound
npm/[email protected] None 0 2.79 kB sindresorhus
npm/[email protected] filesystem 0 7.46 kB lukeed
npm/[email protected] environment, shell 0 15.3 kB sindresorhus
npm/[email protected] None 0 4.23 kB sindresorhus
npm/[email protected] None 0 3.73 kB sindresorhus
npm/[email protected] None 0 5.69 kB sindresorhus

🚮 Removed packages: npm/@babel/[email protected]

View full report↗︎

Copy link

socket-security bot commented Oct 4, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Shell access npm/[email protected] 🚫
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node -e "try{require('./cli/clearCache')}catch(e){console.log(e)}"
⚠︎

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@metamaskbot
Copy link
Collaborator

Builds ready [343b8c5]
Page Load Metrics (1830 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15532144183616177
domContentLoaded15462115179715675
load15542183183016077
domInteractive2783502010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [350f23d]
Page Load Metrics (1904 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30622241823369177
domContentLoaded16442140186810651
load16932228190412761
domInteractive17127522612
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [3cd5ec7]
Page Load Metrics (1958 ± 201 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30527431413664319
domContentLoaded157130881929390187
load158031241958418201
domInteractive23156533216
backgroundConnect8225324722
firstReactRender462071004722
getState4116222914
initialActions01000
loadScripts114626131451350168
setupStore10126292813
uiStartup173136962214505242
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants