Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEP-174 Port features from dicom viewer of HFO project #551

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

GEP-174 Port features from dicom viewer of HFO project #551

wants to merge 11 commits into from

Conversation

aranega
Copy link
Member

@aranega aranega commented Oct 14, 2024 •
edited
Loading

  • removes the dicom viewer internal state
  • add right click support
  • add support for buttons as props
  • add frame redraw perf improvement
  • pass various component state variable as props
  • as the internal state have been removed, the dicom viewer comes now in two flavour to have the equivalent of what we had in Geppetto in the first place:
    • there is the base dicom viewer, handling almost everything as props
    • there is a preconfiguered dicom viewer, adding default behavior for buttons and features that requires to keep an internal state

@aranega
Port features from dicom viewer of HFO project
61171e5 
* removes the dicom viewer internal state
* add right click support
* add support for buttons as props
* add frame redraw perf improvement
* pass various component state variable as props
@aranega
Fix style for dicom viewer component
14405e8
@aranega
Fix refresh of loaded model for dicom viewer
9d3d01d
@aranega aranega changed the title Port features from dicom viewer of HFO project GEP-174 Port features from dicom viewer of HFO project Oct 14, 2024
@aranega aranega marked this pull request as draft October 14, 2024 13:29
@aranega aranega marked this pull request as ready for review October 15, 2024 16:14
@aranega aranega marked this pull request as draft October 15, 2024 16:16
@aranega aranega marked this pull request as ready for review October 16, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippomc filippomc Awaiting requested review from filippomc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aranega