fixing wrong filename written to md5 hash file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easy install
|
I just realized that this includes commits I did not intend to include. Sorry! |
|
This is one of two Pull Requests that were merged into talonius' version of hb-downloader (see https://github.com/talonius/hb-downloader/pull/13 and https://github.com/talonius/hb-downloader/pull/14) I also proposed (and have finished) single product download, see https://github.com/talonius/hb-downloader/issues/12 for details. I was not sure which of the two repositories is more active. I'm sorry for cross-posting to both, that was probably more work for everyone involved. Feel free to cherry-pick any of the thing that you like! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when md5 files are being written, they contain
but this is wrong. The filename that's being referenced does not END in
.md5. Only the hash file does. The correct naming would be:This PR fixes it.