Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About to significantly update the "next" branch... #19

Open
wants to merge 10 commits into
base: next
Choose a base branch
from
Open

Conversation

MayeulC
Copy link
Owner

@MayeulC MayeulC commented Jan 6, 2019

I'll leave that here to get some feedback from the CI system. This is a separate branch, as I also want to run some manual tests on it before merging.

Add more tests for the API and the configuration parser.
The tests are still quite basic, but begin to exercise more code.
This prepares the introduction of a setup.py file and makes things neater.
Also fix imports following the renaming, and add some.
Many thanks to Stefan Zink (@zink-chimaera) in
#11
It stills needs to be in the loop as the item_type subparser is created
there.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 49

  • 58 of 76 (76.32%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+17.5%) to 58.471%

Changes Missing Coverage Covered Lines Changed/Added Lines %
humble_downloader/actions.py 5 7 71.43%
setup.py 0 5 0.0%
humble_downloader/init.py 25 36 69.44%
Totals Coverage Status
Change from base Build 46: 17.5%
Covered Lines: 497
Relevant Lines: 850

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants