Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in preparation for caching plugin #101

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

eileen-kuehn
Copy link
Member

This PR includes several changes in preparation for the setup of the caching plugin, including:

  • fixing api of main components

@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #101 (3e327d5) into master (174fda7) will increase coverage by 1.75%.
The diff coverage is 79.80%.

❗ Current head 3e327d5 differs from pull request most recent head f2999ad. Consider uploading reports for the commit f2999ad to get more accurate results

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   59.89%   61.64%   +1.75%     
==========================================
  Files          15       14       -1     
  Lines         763      777      +14     
  Branches      111      111              
==========================================
+ Hits          457      479      +22     
+ Misses        282      269      -13     
- Partials       24       29       +5     
Impacted Files Coverage Δ
lapis/cli/simulate.py 0.00% <0.00%> (ø)
lapis/controller.py 0.00% <0.00%> (ø)
lapis/pool_io/machines.py 0.00% <0.00%> (ø)
lapis/job_io/htcondor.py 72.97% <63.63%> (-6.52%) ⬇️
lapis/job_io/swf.py 84.37% <70.00%> (-6.54%) ⬇️
lapis/pool.py 47.05% <80.00%> (ø)
lapis/pool_io/htcondor.py 78.94% <85.71%> (+2.02%) ⬆️
lapis/workernode.py 75.23% <90.00%> (ø)
lapis/job.py 81.25% <90.90%> (-0.29%) ⬇️
lapis/monitor/cobald.py 89.47% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174fda7...f2999ad. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Dec 14, 2020

Hello @eileen-kuehn! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-06 21:02:45 UTC

@lgtm-com
Copy link

lgtm-com bot commented May 6, 2022

This pull request introduces 1 alert when merging f2999ad into 174fda7 - view on LGTM.com

new alerts:

  • 1 for Unguarded next in generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants