Caller Hiearchy shows lines of each reference in caller, not start li… #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and position-style ranges
https://bugs.llvm.org/show_bug.cgi?id=37695 is not fixed. But since we have eliminated libclang for indexing and completion the bug no longer bothers us.
* Make CXXConstructor span one more column to left/right * Use OrigD to collect Decl::Record members * Better comment parsing * Limit lines of initializers and macro definition to 3 * Attribute macro arg uses to spelling loc * Remove FuncDef::declaring_type
Also change StorageClass storage to uint8_t
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
536c07b
to
bfac216
Compare
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
e0c921f
to
468a2fb
Compare
MaskRay
force-pushed
the
master
branch
2 times, most recently
from
b299069
to
de800eb
Compare
MaskRay
force-pushed
the
master
branch
2 times, most recently
from
7818055
to
99f0b40
Compare
MaskRay
force-pushed
the
master
branch
4 times, most recently
from
a33231a
to
cb08df4
Compare
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
ee29996
to
feb153a
Compare
MaskRay
force-pushed
the
master
branch
9 times, most recently
from
94ba2b3
to
c018bce
Compare
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
db890d4
to
cc13ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As like other IDEs (Eclipse, ..) , it's better to show line of each reference in caller hiearchy,
Instead of caller's start line.
For example, if caller has a lots of lines, it's annoying to find which line calls current symbol in which context or condition.