Don't force recreating the map object and associated layer state #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpoole
force-pushed
the
retain_map_object_if_it_still_exists
branch
2 times, most recently
from
f77bd76 to
993074b
Compare
simonpoole
force-pushed
the
retain_map_object_if_it_still_exists
branch
from
993074b to
86d40f6
Compare
If Main has been destroyed, both the Map and Logic objects may still be available and current, so we now reuse them instead of forcing recreation. This resolves race conditions that could be caused by selecting and loading files into layers via the system file picker that could lead to Main being removed.
simonpoole
force-pushed
the
retain_map_object_if_it_still_exists
branch
from
86d40f6 to
69914ea
Compare
simonpoole
force-pushed
the
retain_map_object_if_it_still_exists
branch
from
69914ea to
e7c5089
Compare
simonpoole
force-pushed
the
retain_map_object_if_it_still_exists
branch
from
ead348e to
34c9986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Main has been destroyed, both the Map and Logic objects may still be available and current, so we now reuse them instead of forcing recreation.
This resolves race conditions that could be caused by selecting and loading files into layers via the system file picker that could lead to Main being removed.