-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the Android build instructions. #1779
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping with improving documentation.
Could you make the suggested changes so that we can merge those improved instructions in the codebase?
Thanks!
|
||
Copy the headers into the build folder | ||
``` | ||
mkdir -p ../build-android/include/MailCore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we could make sure build.sh does it for us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the build.sh script to take care of it instead of adding more instructions?
Open terminal and set two temporary export variables | ||
* (Make sure they point to your SDK and NDK folders) | ||
``` | ||
export ANDROID_SDK=/Users/YOURNAME/Library/Android/sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you keep it as /path/to/android-sdk (and maybe provide a specific example).
Like
$ export ANDROID_SDK=/path/to/android-sdk # /Users/username/Library/Android/sdk
* (Make sure they point to your SDK and NDK folders) | ||
``` | ||
export ANDROID_SDK=/Users/YOURNAME/Library/Android/sdk | ||
export ANDROID_NDK=/Users/YOURNAME/Downloads/android-ndk-r13b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downloads is not a great path to install a SDK/NDK ;)
|
||
Install Java 6, 8, or 10 | ||
* http://www.oracle.com/technetwork/java/javase/downloads/jdk10-downloads-4416644.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try not being too specific with downloads URLs?
Java version will evolve over time and I'd like to avoid changing these instructions too often.
* http://www.oracle.com/technetwork/java/javase/downloads/jdk10-downloads-4416644.html | ||
* Building with Java 8 or 10 might throw a few warnings during the build, but it will still build | ||
|
||
Download the Required Android SDKs (16, 21, 22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with Android SDK and NDK.
Fyi: #1912 explains the build pipeline on Android that works also in 2021 |
Tested on multiple Macs running High Sierra.