Discourage installation for ST4 users #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would probably also be a good idea to outright disable installation of MagicPython for ST4 users altogether. I can quickly make that change if you agree to it, but I want to confirm this with you first as there may still be some reason that users would want to use MagicPython over the default that I don't know about. |
|
Bump. |
FichteFoll
added a commit
to wbond/package_control_channel
that referenced
this pull request
Oct 29, 2023
There is very little reason to do this when the default syntax definition is much better due to using the `sublime-syntax` format, follows the scope naming standards and is actively maintained, because this package hasn't had a tag pushed in 4 years despite seeing *some* changes, albeit the last one over a year ago. A pull request asking for clarification of the support status for ST4 has not been answered for 8 months. MagicStack/MagicPython#255
I've gone ahead and did that. We will probably merge it soon, although it can easily be reverted. However, I currently don't see any reason for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package is behind the default Python syntax in adopting new syntax features and in adhering to the scoping standards that the community has established for the default packages. It also has access to branching and can thus reliably detect whether a curly brace begins a set or a dict literal over multiple lines.
Besides, the latest update installable via Package Control has been released over 4 years ago because no tag has been pushed to the repo since and that is required for Package Control to pick up new versions.
Thus, I propose to discourage installation for ST4 users. Users of older versions may still want to install it because their default packages won't receive any updates anymore. You should also push a new tag to the repo to allow installation of the latest changes for ST users of older versions.