Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #366

Merged
merged 9 commits into from
May 1, 2024
Merged

Fix CI #366

merged 9 commits into from
May 1, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 27, 2024

UserGuide CI has been broken for ~2 months.. let's try to fix it

In this PR:

  • Bump up Python to 3.10
  • Unpin dask in env file
  • Update hole2 things
  • Skip testing output of eigenvectors in diffusion_map

📚 Documentation preview 📚: https://mdanalysisuserguide--366.org.readthedocs.build/en/366/

@IAlibay
Copy link
Member Author

IAlibay commented Apr 27, 2024

As predicted in #345 (comment) : it looks like the signs in diffusion_map have flipped again.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@IAlibay
Copy link
Member Author

IAlibay commented Apr 27, 2024

Unpinning dask seems to work perfectly fine (tested this locally). Which means that this #242 is probably no longer relevant.

@@ -36,14 +36,14 @@ dependencies:
- scikit-image
- seaborn>=0.12.1
# parallelization
- distributed==2021.1.0
- dask==2021.1.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping these pinned would prevent us from increasing the python version

environment.yml Outdated Show resolved Hide resolved
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IAlibay, LGTM. And sorry I did not have time to look into this before.

@IAlibay IAlibay merged commit 66b1cf8 into develop May 1, 2024
4 checks passed
@IAlibay
Copy link
Member Author

IAlibay commented May 1, 2024

Thanks @RMeli !

@RMeli RMeli deleted the fix-ci-python branch July 17, 2024 07:51
@RMeli RMeli mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants