Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle extended colour codes #332

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kurahaupo
Copy link
Contributor

  • handle mIRC extended colour codes 16~98
  • handle ANSI escape-sequences for colour codes and other attributes

@kurahaupo
Copy link
Contributor Author

(please squash before merging)

@kurahaupo
Copy link
Contributor Author

This patch also fixes a bug where a digit following a colour code would sometimes be taken to be part of that code. (It ensures that when sending a colour code, it always ends with two digits when it's followed by a literal digit).

It also applies some minor optimisations to send bold/italic/underline to reset those attributes (since they're defined to be toggles), rather than sending a reset and the have to re-enable all other attributes. (It still sends a reset when intending to reach the default state, to minimise the effects in other clients that might mishandle toggled attribute.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant