Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic operator actions menu in whois dialog #292

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mkromar
Copy link

@mkromar mkromar commented Mar 25, 2021

  • Move notification title into strings.xml
  • Add a basic operator actions menu in whois dialog

This pull request adds a basic operator actions menu in the whois dialog.

It covers all of the features requested by #82 and #262, except for ping, which would be simple to add if needed.

@MCMrARM
Copy link
Owner

MCMrARM commented May 6, 2021

Can you post a screenshot?

@MCMrARM
Copy link
Owner

MCMrARM commented May 6, 2021

Code-wise this PR is mostly fine (althrough it would be better to not use hardcoded indexes in the string list; IMO it would be better to build the list from Java; also probably would be best to move hostname before away in setUser), so if it looks OK I can merge it.

@mkromar
Copy link
Author

mkromar commented Jun 26, 2021

Sorry for the late reply, somehow I missed the email.

Here's a short video showing how it looks/works.

I went with the hardcoded list as it was the easiest way to quickly prototype it, but I agree that it's not the correct way to do it.

Another thing I noticed is that it would probably be wise to check mChannel and mNick in executeAction(), even though I haven't noticed any problems while using it.

I'll update the PR when I have some more free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants