-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wider layout, is it better? #158
Conversation
I can see arguments both for and against. Let's get some test branches on other repos with this, to see how it looks? I can do GeoMakie for example, and probably DimensionalData is a good bet as well... |
+1 for this. If not by default (personally, I think this is a better default), we should have an option to opt-in to this format. Currently the navigation bar seems to be aligned incorrectly |
Also maybe a little more spacing on the left? The anchors ("#") seem almost too close to the left sidebar |
+1 from me! I tried to do this a while ago, but got lost in a web of Vitepress issues and css hell. |
Ok. Latest commit should give better paddings. @asinghvi17 it looks like your tests are not using this branch, or is not using the style from the template. If there is not more feedback, this should be good to go. Thanks everyone for chiming in 😄 . |
Yeah the style isn't applied. Will fix that. |
really good catch! Latest commit should fix that. |
Looks quite nice https://lux.csail.mit.edu/previews/PR721/tutorials/ 🎉 |
Good point! Though the downside is it also appears in the titlebar, so it would appear as "XYZ | Documentation". I will go with "Lux.jl Docs" to prevent the overflow for now. |
Ok, final version, it turns out we only need this: .VPDoc.has-aside .content-container {
max-width: 100% !important;
}
.aside {
max-width: 200px !important;
padding-left: 0 !important;
}
.VPDoc {
padding-top: 15px !important;
padding-left: 5px !important;
}
/* This one does the right menu */
.VPDocOutlineItem li {
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
max-width: 200px;
}
.VPNavBar .title {
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
}
@media (max-width: 960px) {
.VPDoc {
padding-left: 25px !important;
}
} the previous approach expands the whole available screen (which is fine, maybe?), but this last one keeps the content centered while also having a wider area for it. Hence, I will settled for this and merge 😄 . |
This should gives additional space. Similar to the width from vanilla Documenter.