-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quote integration as optional printing feature #13
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[package] | ||
name = "litrs" | ||
version = "0.4.0" | ||
version = "0.4.1" | ||
authors = ["Lukas Kalbertodt <[email protected]>"] | ||
edition = "2018" | ||
rust-version = "1.54" | ||
|
@@ -25,9 +25,11 @@ exclude = [".github"] | |
|
||
|
||
[features] | ||
default = ["proc-macro2"] | ||
default = ["proc-macro2", "printing"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't make it a default feature. In fact, I consider removing |
||
check_suffix = ["unicode-xid"] | ||
printing = ["dep:quote"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mh this feature requires Rust 1.60, but currently this is targetting 1.54. So if we want this, I would only release that with a major version bump. While I dislike implicit features and do think Also, independently: I guess this should also mention |
||
|
||
[dependencies] | ||
proc-macro2 = { version = "1", optional = true } | ||
proc-macro2 = { version = "1", optional = true } | ||
unicode-xid = { version = "0.2.4", optional = true } | ||
quote = { version = "1", optional = true, no-default-features = true } | ||
Comment on lines
-32
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please don't align it like that. Just one space after the comma. and before the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will bump the version as part of my release process. At least in my workflow, this doesn't belong into feature commits.