Add Validation via #[config(validate)]
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
changed the title
#config(validate)]#[config(validate)]
Previously, code for each method was generated by one iterator each, which was nice since it avoided allocating memory. However, this meant that each block had its own `match field.kind` basically, which lead to lots of duplication and put code close to one another that's not really related (dealing with nested fields and leaf fields). The new approach does require allocating vectors (but that's really irrelevant in the proc macro context), but has one function deal with one field at a time, generating all relevant code for it. This co-locates related code and should make certain changes much easier.
This was planned from the beginning, but was missing in the previous commits. Validation should always run, regardless where the value comes from.
LukasKalbertodt
force-pushed
the
validation
branch
from
26ee55c
to
8fd9ddd
Compare
LukasKalbertodt
force-pushed
the
validation
branch
from
8fd9ddd
to
4b6a8fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
validateattribute that can be attached to structs or struct fields. Its syntax isvalidate = path::to::functionwhere the function takes&Tand returnsResult<(), impl Display>. For struct fields, a secondassert!-style syntax exists:validate(!name.is_empty(), "name must not be empty").See the added docs for more information.
Closes #16