Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4538: Breed sorting does not work in inventory table #3558

Open
wants to merge 4 commits into
base: integration
Choose a base branch
from

Conversation

SayakaOno
Copy link
Collaborator

Description

  • Update descendingComparator to handle undefined and null as expected.
  • Add tests. (pnpm run test sort)

Jira link: https://lite-farm.atlassian.net/browse/LF-4538

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno added the bug Something isn't working label Dec 3, 2024
@SayakaOno SayakaOno self-assigned this Dec 3, 2024
@SayakaOno SayakaOno requested review from a team as code owners December 3, 2024 00:00
@SayakaOno SayakaOno requested review from antsgar and Duncan-Brain and removed request for a team December 3, 2024 00:00
Copy link
Collaborator

@antsgar antsgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants