Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: info route #368

Merged
merged 6 commits into from
Nov 27, 2024
Merged

feat: info route #368

merged 6 commits into from
Nov 27, 2024

Conversation

lorenzomassimiani
Copy link
Contributor

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Add info route as explained in issues 366. Tests were included.

@lorenzomassimiani
Copy link
Contributor Author

I added a commit where I solved pre-commit format issues.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (fbeb010) to head (b921ee6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #368    +/-   ##
====================================
- Coverage    94%    94%    -1%     
====================================
  Files        23     25     +2     
  Lines      1459   1577   +118     
====================================
+ Hits       1376   1478   +102     
- Misses       83     99    +16     

tests/test_info.py Outdated Show resolved Hide resolved
tests/test_lit_server.py Show resolved Hide resolved
@aniketmaurya
Copy link
Collaborator

Looking good @lorenzomassimiani! added few minor comments.

@aniketmaurya aniketmaurya linked an issue Nov 27, 2024 that may be closed by this pull request
@aniketmaurya
Copy link
Collaborator

Hi @lorenzomassimiani, to fix the pre-commit check, you can install the pre-commit hook as follows:

pip install pre-commit
pre-commit install

Add an empty line on the files that you have changed and commit the changes. Pre-commit will automatically format and fix the issues.

Also, please move the test_info.py code to test_lit_server.py.

Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @lorenzomassimiani

@lorenzomassimiani
Copy link
Contributor Author

thanks to you, it's a pleasure to contribute to the project! @aniketmaurya

@aniketmaurya aniketmaurya merged commit 7d4e112 into Lightning-AI:main Nov 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Info route
2 participants