Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batcher): altda concurrent blob submissions respect holocene strict ordering rules #14

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

fix(batcher): altda concurrent blob submissions respect holocene strict ordering rules #14

wants to merge 5 commits into from
+862 −87

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Dec 1, 2024 •
edited
Loading

This PR contains 2 commits:

  1. test (which is currently failing) that has the fakeDAServer return blobs out of order: 28cc938
  2. batcher fix: 44b960c

Still some things to do here, but opening the PR for a first architecture review, to see if the approach even makes sense.

Left some TODOs in the code, main ones are:

  1. Architectural question: should we store the pending altda commitments inside the channels instead of channelManager
  2. testing edge cases (reorgs, tx failed, channe timeout)

@samlaf samlaf marked this pull request as draft December 1, 2024 17:52
@samlaf samlaf force-pushed the fix--batcher-altda-concurrent-blobs-respect-strict-holocene-order branch 4 times, most recently from 8166355 to d80a4d3 Compare December 8, 2024 02:29
@samlaf samlaf force-pushed the fix--batcher-altda-concurrent-blobs-respect-strict-holocene-order branch from d80a4d3 to c19ec47 Compare December 9, 2024 18:33
@samlaf
test(e2e): new altda e2e test for concurrent blob submissions to main…
bebf7bb 
…tain new holocene strict ordering rules
@samlaf
test(batcher): new unit tests for unhappy failure cases (currently on…
a6c2830 
…ly for altda)

test(batcher): fix flaky driver tests + speed them up

test(batcher): robustify batcher driver altda tests
@samlaf
fix(batcher): altda concurrent blob responses are reordered to respec…
3cbe31f 
…t holocene strict ordering rules
@samlaf
fix(batcher): sync_actions data race
0a8bbe4 
computeSyncActions function of main goroutine is racing with the tx processing goroutine because it calls the channel functions directly without passing by the channelManager (which holds the lock). Fixed by passing channelManager lock to computeSyncActions
@samlaf
test(batcher): add failpoint-based test to trigger and test channelTi…
a43ed4d 
…meout logic
@samlaf samlaf force-pushed the fix--batcher-altda-concurrent-blobs-respect-strict-holocene-order branch from a1c0d94 to a43ed4d Compare December 10, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samlaf