Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Arbitrator 2mb blob test #26

Open
wants to merge 4 commits into
base: eigenda-v3.0.3
Choose a base branch
from

Conversation

epociask
Copy link
Collaborator

@epociask epociask commented Aug 9, 2024

Description

  • Additional large blob test which asserts that a machine state proof can be generated at an offset > 127kb

Currently 2MB blob pre-images proofs can't be serialized when there's > 1 during execution.

@epociask epociask requested review from hopeyen and bxue-l2 August 12, 2024 23:34
Copy link

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool:) wish upstream had more comprehensive tests

out Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my understanding, what is this file and did you mean to include this?

preimage_ty,
hex::encode(hash),
size
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need to remove this.

Copy link

@bxue-l2 bxue-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@epociask epociask changed the base branch from fixing-proof-calculation to eigenda-v3.0.3 August 29, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants