Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Extend the length of underline #1853

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arhcout
Copy link
Contributor

@Arhcout Arhcout commented Oct 18, 2024

Fix #1822.

@ladybird-bot
Copy link
Collaborator

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

This is fix any gaps that appear with text-align: justify
@ronak69
Copy link
Contributor

ronak69 commented Oct 18, 2024

This change does fix the issue. But do you know why it was an issue in the first place?

Why the need to extend the underline? (I don't know why it was already 1 pixel short at the end before)

I also trid to fix this and thought the bug might be in here:

void InlineFormattingContext::apply_justification_to_fragments(CSS::TextJustify text_justify, LineBox& line_box, bool is_last_line)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link have gap in underline with text-align: justify
3 participants